Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(job): validate jobKey in updateProgress and update #2730

Merged
merged 1 commit into from May 10, 2024
Merged

fix(job): validate jobKey in updateProgress and update #2730

merged 1 commit into from May 10, 2024
+81 −10

Conversation

roggervalf
Copy link
Collaborator

@roggervalf roggervalf commented May 4, 2024 •
edited

Using updateProgress and update method after a job is removed, re-add a jobKey but only with data or progress attribute

manast
manast approved these changes May 10, 2024
View reviewed changes
Copy link
Member

@manast manast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@roggervalf roggervalf merged commit 6d84156 into OptimalBits:develop May 10, 2024
6 checks passed
github-actions bot pushed a commit that referenced this pull request May 10, 2024
@semantic-release-bot
chore(release): 4.12.3 [skip ci]
afcf11c 
## [4.12.3](v4.12.2...v4.12.3) (2024-05-10)

### Bug Fixes

* **job:** validate jobKey in updateProgress and update ([#2730](#2730)) ([6d84156](6d84156))

### Performance Improvements

* **scripts:** remove token after moving to wait or delayed ([#2731](#2731)) ([7ee8f74](7ee8f74))
@manast
Copy link
Member

manast commented May 10, 2024

🎉 This PR is included in version 4.12.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@roggervalf roggervalf deleted the fix-update-check-key-existence branch May 10, 2024 13:59
@roggervalf roggervalf mentioned this pull request May 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manast manast manast approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@roggervalf @manast