Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pass redis string as opts into queue #2664

Merged
merged 1 commit into from Nov 11, 2023

Conversation

Shinigami92
Copy link
Contributor

closes #2663

Copy link

stale bot commented Nov 10, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Nov 10, 2023
@Shinigami92
Copy link
Contributor Author

Why stale? I didn't get a review yet?!

@stale stale bot removed the wontfix label Nov 10, 2023
@manast
Copy link
Member

manast commented Nov 10, 2023

Sorry, these days we are not spending a lot of effort in Bull unless it is a critical issue. For some reason, in this particular PR the tests have not run, thats very strange.

@Shinigami92
Copy link
Contributor Author

Sorry, these days we are not spending a lot of effort in Bull unless it is a critical issue. For some reason, in this particular PR the tests have not run, thats very strange.

So how can I help with bringing this forward?
Should I take a look into your GitHub Actions CI and try to find out why it's not running? (No irony in this! I mean this for real and I'm willing to help.)

@Shinigami92
Copy link
Contributor Author

I made a rebase and merged the last 4 commits from develop
Now the workflow needs an approval from a maintainer of the repo
I greatly assume then the tests will run

These workflow approvals came in one or two years ago and where activated automatically
You can configure them in your repo under Settings -> Actions -> General -> Fork pull request workflows from outside collaborators
image

@manast manast merged commit e94f568 into OptimalBits:develop Nov 11, 2023
6 checks passed
@manast
Copy link
Member

manast commented Nov 11, 2023

Thanks for the PR 👍

@Shinigami92 Shinigami92 deleted the fix/queue-redis-opts-string branch November 11, 2023 12:09
@manast
Copy link
Member

manast commented Nov 11, 2023

🎉 This PR is included in version 4.11.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Shinigami92
Copy link
Contributor Author

🎉 This PR is included in version 4.11.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

I will update my project on monday at work 👍
Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] constructor with options does not destructure redis property if it is a string
2 participants