Fix return type of getJobCountByTypes #2622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR. Indeed it was wrong in the typings. |
github-actions bot
pushed a commit
that referenced
this pull request
Aug 8, 2023
# [4.11.0](v4.10.4...v4.11.0) (2023-08-08) ### Bug Fixes * add mising getMetrics type ([#2640](#2640)) ([a217a7d](a217a7d)) * remove deprecated debuglog ([4ce36fe](4ce36fe)) * **types:** add missing keys to repeat opts ([e4e6457](e4e6457)) * **types:** rename strategyOptions to options to reflect js file ([bae6427](bae6427)) * **typings:** return type of getJobCountByTypes ([#2622](#2622)) ([47722ed](47722ed)) * **worker:** high-memory-usage-when-providing-float-to-concurrency ([#2620](#2620)) ([dcca1e8](dcca1e8)) * change option name to match ts declaration ([909a07e](909a07e)) * ts declaration metrics option and getMetrics function ([11331b7](11331b7)) ### Features * upgrade ioredis to 5.3.2 ([e1883f0](e1883f0))
|
🎉 This PR is included in version 4.11.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The return type of
getJobCountByTypes(types: JobStatus[] | JobStatus)is invalid;It is a number, not a JobCounts;
Another proof is that function
count()usesgetJobCountByTypesand yet returns a number;