Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade semver version 7.3.2 to 7.5.2 #2617

Merged
merged 2 commits into from Jun 22, 2023

Conversation

vohongtho
Copy link
Contributor

The lib semver version 7.3.2 has vulnerable (Regular Expression Denial of Service (ReDoS)),
https://security.snyk.io/vuln/SNYK-JS-SEMVER-3247795

Please accept this request!

@manast
Copy link
Member

manast commented Jun 22, 2023

Thanks. Even though the vulnerability does not affect us, since we use semver in a controlled way (with a fixed version string and the version taken from the Redis host), we can upgrade to avoid the warning.

@manast
Copy link
Member

manast commented Jun 22, 2023

Btw, you also need to update yarn.lock, otherwise the tests will not pass.

@vohongtho
Copy link
Contributor Author

vohongtho commented Jun 22, 2023 via email

@manast manast merged commit 4b8a386 into OptimalBits:develop Jun 22, 2023
5 checks passed
@manast
Copy link
Member

manast commented Aug 8, 2023

🎉 This PR is included in version 4.11.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@manast manast added the released label Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants