Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more detail about timeouts and startDate to the reference #2199

Merged
merged 5 commits into from Dec 14, 2021

Conversation

cincodenada
Copy link
Contributor

@cincodenada cincodenada commented Nov 4, 2021

It was unclear what happens when a job times out, and one might assume the job is somehow stopped, which is impossible for non-sandboxed jobs, and not implemented for sandboxed jobs. Add a little explainer to make this clear.

Relevant issues: #2166, #479

@cincodenada
Copy link
Contributor Author

This makes reference to jobPromise.cancel(), which I believe is broken per #2203 - pending the result of that ticket, that reference should be removed or updated.

@manast manast merged commit e5cc075 into OptimalBits:develop Dec 14, 2021
@manast
Copy link
Member

manast commented Dec 14, 2021

🎉 This PR is included in version 4.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants