chore: cleanup whenCurrentJobsFinished #1542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabegorelick
commented
Nov 6, 2019
| @@ -1174,49 +1174,20 @@ Queue.prototype.clean = function(grace, type, limit) { | |||
| * @returns {Promise} | |||
| */ | |||
| Queue.prototype.whenCurrentJobsFinished = function() { | |||
| return new Promise((resolve, reject) => { | |||
There was a problem hiding this comment.
Removing the unnecessary new Promise.
gabegorelick
commented
Nov 6, 2019
| this.bclient.once('end', function(){ | ||
| console.error('ENDED!'); | ||
| setTimeout(function(){ | ||
| this.bclient.connect(); |
There was a problem hiding this comment.
Removed all this commented code.
Cleanup and document whenCurrentJobsFinished. And since it's now official API, add some tests for it.
gabegorelick
force-pushed
the
whenCurrentJobsFinished
branch
from
edde75c
to
d13d99d
Compare
1 similar comment
manast
approved these changes
Nov 6, 2019
holm
reviewed
Dec 11, 2019
| } | ||
| */ | ||
| //this.bclient.connect(); | ||
| return Promise.all([this.processing[0]]).then(() => { |
There was a problem hiding this comment.
After upgrade to latest version of bull we are seeing that on shutdown, it doesn't properly wait for all jobs to complete.
It seems to me that this is likely the change that caused the problem. Was it intentional to change this to only wait for the first job?
There was a problem hiding this comment.
No, that seems like a dumb mistake on my part. Thanks for catching it @holm.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup and document whenCurrentJobsFinished. And since it's now official API, add some tests for it.