fix: whenCurrentJobsFinished should wait for all jobs #1586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabegorelick
force-pushed
the
wait-multiple-jobs
branch
from
ebacd76
to
d3c1527
Compare
|
Managed to add a test. |
|
Would be good to have this merged and released |
|
@manast it would be good to get this released. Users keep reporting this bug. |
|
Looks great. I had missed this PR completely. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're currently only waiting for the first job to finish, not all active jobs.
See https://github.com/OptimalBits/bull/pull/1542/files#r356810178
Fixes #1616