refactor(api,hardware): use new pipette node ids #9363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the version of opentrons_ot3_firmware and use the new pipette_right and pipette_left node ids, which also requires updating and fixing some tests.
Update opentrons_ot3_firmware and use the new pipette_left and pipette_right node ids.
Codecov Report
@@ Coverage Diff @@
## ot3-5.0-work #9363 +/- ##
================================================
- Coverage 75.78% 75.41% -0.37%
================================================
Files 1859 1857 -2
Lines 51942 51128 -814
Branches 4783 4783
================================================
- Hits 39364 38558 -806
+ Misses 11693 11685 -8
Partials 885 885
Flags with carried forward coverage won't be shown. Click here to find out more.
|
sfoster1
added a commit
that referenced
this pull request
Feb 4, 2022
* refactor(hardware): use new pipette node ids Update the version of opentrons_ot3_firmware and use the new pipette_right and pipette_left node ids, which also requires updating and fixing some tests. * refactor(api): use new pipette node ids Update opentrons_ot3_firmware and use the new pipette_left and pipette_right node ids.
Kadee80
pushed a commit
that referenced
this pull request
Feb 10, 2022
* refactor(hardware): use new pipette node ids Update the version of opentrons_ot3_firmware and use the new pipette_right and pipette_left node ids, which also requires updating and fixing some tests. * refactor(api): use new pipette node ids Update opentrons_ot3_firmware and use the new pipette_left and pipette_right node ids.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the new
pipette_leftandpipette_rightnode ids and use them in hardware and api.This bumps the
opentrons_ot3_firmwareversions in both. Also need to correctly specify mypy, which needs to stay at 0.910 until we update pydantic to a version that includes pydantic/pydantic#3175On merging this PR, move commands sent to an OT-3 system will likely no longer terminate because by default they'll send to both pipettes even if just one is attached.