Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(opentrons-ai-client): fix ChatContainer layout issue #15182

Merged
merged 1 commit into from
May 16, 2024

Conversation

koji
Copy link
Contributor

@koji koji commented May 14, 2024

Overview

fix ChatContainer layout issue.
update the ChatContainer layout.

after

Screenshot 2024-05-14 at 3 43 26 PM

close AUTH-397

Test Plan

  1. make -C opentrons-ai-client dev
  2. type something and send button
  3. repeat step 2 a couple of times
    Check all your messages are displayed correctly.

Changelog

Review requests

Risk assessment

low

@koji koji requested review from Elyorcv and ncdiehl11 May 14, 2024 19:50
@koji koji marked this pull request as ready for review May 14, 2024 19:50
@koji koji requested a review from a team as a code owner May 14, 2024 19:50
@koji koji removed the request for review from a team May 14, 2024 21:10
@Elyorcv
Copy link
Contributor

Elyorcv commented May 14, 2024

@koji When I continue submit again and again, it does not create scroll bar. Instead, it gets long
Screenshot 2024-05-14 at 10 34 44 PM

@koji koji requested review from y3rsh and shlokamin May 14, 2024 23:15
@koji
Copy link
Contributor Author

koji commented May 14, 2024

@koji When I continue submit again and again, it does not create scroll bar. Instead, it gets long Screenshot 2024-05-14 at 10 34 44 PM

Did you set any specific settings on your Mac like this?

I think the app always shows the scrollbar because of the side bar's height.

@Elyorcv
Copy link
Contributor

Elyorcv commented May 14, 2024

need to choose always?
image

@Elyorcv
Copy link
Contributor

Elyorcv commented May 14, 2024

@koji When I continue submit again and again, it does not create scroll bar. Instead, it gets long Screenshot 2024-05-14 at 10 34 44 PM

Did you set any specific settings on your Mac like this?

I think the app always shows the scrollbar because of the side bar's height.

I tried default and always versions, but the same effect

@koji
Copy link
Contributor Author

koji commented May 15, 2024

@koji When I continue submit again and again, it does not create scroll bar. Instead, it gets long Screenshot 2024-05-14 at 10 34 44 PM

Did you set any specific settings on your Mac like this?
I think the app always shows the scrollbar because of the side bar's height.

I tried default and always versions, but the same effect

hmm, I cannot reproduce the issue.
Are you using Chrome?

@Elyorcv
Copy link
Contributor

Elyorcv commented May 15, 2024

@koji When I continue submit again and again, it does not create scroll bar. Instead, it gets long Screenshot 2024-05-14 at 10 34 44 PM

Did you set any specific settings on your Mac like this?
I think the app always shows the scrollbar because of the side bar's height.

I tried default and always versions, but the same effect

hmm, I cannot reproduce the issue. Are you using Chrome?

To be clear, there are two scrollbars: one is outside chat container which belong to chrome; another one is for the chat container itself. My problem is for the chat container. When you send many messages, it just extends without scrollbar.

Copy link
Collaborator

@y3rsh y3rsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked good in the demo branch.

@koji koji merged commit 9c739b6 into edge May 16, 2024
18 checks passed
@koji koji deleted the fix_ChatCointainer-layout-issue branch May 16, 2024 14:58
Carlos-fernandez pushed a commit that referenced this pull request May 20, 2024
* fix(opentrons-ai-client): fix ChatContainer layout issue
Carlos-fernandez pushed a commit that referenced this pull request Jun 3, 2024
* fix(opentrons-ai-client): fix ChatContainer layout issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants