feat(shared-data, api): add absorbance plate reader definition and module control #15167
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## edge #15167 +/- ##
=======================================
Coverage 92.43% 92.43%
=======================================
Files 77 77
Lines 1283 1283
=======================================
Hits 1186 1186
Misses 97 97
Flags with carried forward coverage won't be shown. Click here to find out more. |
| ) -> Tuple[ErrorCode, bool]: | ||
| ... | ||
|
|
||
| def byonoy_abs96_get_available_wavelengths( |
There was a problem hiding this comment.
are these all commands you access through the hid interface?
There was a problem hiding this comment.
Yes they are! So we'd have to update this file and the AsyncByonoy whenever the byonoy library gets updated.
| @@ -280,6 +280,15 @@ | |||
| ], | |||
| "version": "==4.2.2" | |||
| }, | |||
| "pyusb": { | |||
There was a problem hiding this comment.
Do we want to include all these changes to the lock file or just whats required to include pyusb?
…dule control (#15167) <!-- Thanks for taking the time to open a pull request! Please make sure you've read the "Opening Pull Requests" section of our Contributing Guide: https://github.com/Opentrons/opentrons/blob/edge/CONTRIBUTING.md#opening-pull-requests To ensure your code is reviewed quickly and thoroughly, please fill out the sections below to the best of your ability! --> # Overview This PR adds support for the Absorbance Plate Reader in the hardware controller API. We can now see the plate reader as an attached module on the backend and use the AbsorbanceReaderDriver to communicate with the plate reader like we would with the other modules. # Caveat The driver is not fully finished - there are some functions that still need to be implemented and I expect the format of the response will change depending on how we implement the engine commands. We still need to add some changes on oe-core side to make sure this runs on all robot - however i'm happy to show you the plate reader in action at this time.
Overview
This PR adds support for the Absorbance Plate Reader in the hardware controller API. We can now see the plate reader as an attached module on the backend and use the AbsorbanceReaderDriver to communicate with the plate reader like we would with the other modules.
Caveat
The driver is not fully finished - there are some functions that still need to be implemented and I expect the format of the response will change depending on how we implement the engine commands.
We still need to add some changes on oe-core side to make sure this runs on all robot - however i'm happy to show you the plate reader in action at this time.