Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(opentrons-ai-client): update api call functions for simulator api #15121

Open
wants to merge 6 commits into
base: edge
Choose a base branch
from

Conversation

koji
Copy link
Contributor

@koji koji commented May 7, 2024

Overview

add an util function to detect a command that is for calling simulator api. The function will be used for the bench marking test in the future.

Right now we are calling opentrons simulator api server (on HuggingFace) via OpenAI API function calling but we think we might want to call it directly to have full control.

The util function detects specific keywords (simulate).

close AUTH-388

Test Plan

There is no change about the application itself.
Need to regex is okay and test cases are enough.

Changelog

Review requests

Risk assessment

low

@koji koji added the authorship label May 7, 2024
@koji koji marked this pull request as ready for review May 8, 2024 15:11
@koji koji requested a review from a team as a code owner May 8, 2024 15:11
@koji koji closed this May 8, 2024
@koji koji reopened this May 8, 2024
@koji koji marked this pull request as draft May 8, 2024 16:35
@koji koji requested review from ncdiehl11 and jerader May 10, 2024 14:30
@koji koji removed the request for review from a team May 10, 2024 14:36
@koji koji marked this pull request as ready for review May 10, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant