New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow configuring custom web3 instance #38
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to add the new integration test to the .travis.yaml file for it to actually run.
Sorry, let me add some documentation and a changelog entry. |
@nventuro Done. I also changed the API slightly. It is now called
|
This reverts commit a918899.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fantastic @frangio, thanks a lot!
Fixes #35
Removes the assumption that there is a global web3 (as in a Truffle environment) by adding a mechanism to manually configure the web3 instance. Also allows using in Truffle migrations (OpenZeppelin/openzeppelin-contracts#1743).
Also where possible replaces
web3.utils
by theweb3-utils
package.