Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ERC1820 deploy address and transaction data. #26

Merged
merged 3 commits into from Apr 10, 2019

Conversation

nventuro
Copy link
Contributor

@nventuro nventuro commented Apr 9, 2019

The ERC1820 EIP was recently updated (minor documentation changes), but this caused an address change. The EIP is now final, so we should reflect this new address here.

Note that these changes are made on top of v0.3.1, not master, so that we can release a new minor version without the new master changes. Perhaps we should merge this into a separate branch?

@nventuro nventuro requested a review from frangio April 9, 2019 22:02
Copy link
Contributor

@frangio frangio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sounds like we should deprecate v0.3.1 on npm. What do you think?

@nventuro
Copy link
Contributor Author

nventuro commented Apr 9, 2019

Why would we do that? singletons were introduced before v0.3.0 even iirc, should we deprecate all published versions as well?

@frangio
Copy link
Contributor

frangio commented Apr 9, 2019

Yeah, I don't know. Okay.

@nventuro nventuro merged commit 1996754 into master Apr 10, 2019
@nventuro nventuro deleted the v0.3.2-erc1820-hotfix branch April 10, 2019 21:59
nventuro added a commit that referenced this pull request Apr 10, 2019
* Update ERC1820 deploy address and transaction data.

* Add changelog entry.

(cherry picked from commit 1996754)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants