Fix expectRevert accepting partial matches #152
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug caused tests using
expectRevert
to pass despite the revertReason not fully being correct because of the use ofString.prototype.indexOf
to verify if the correct revert reason was contained in the error string. To fix it more robust error parsing logic was added; it is compatible with both old and new VM Exception strings.Discovered this bug in my personal project, tests were passing despite the revert messages not fully being identical.