Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove shouldFail.reverting.withMessage #30

Closed
nventuro opened this issue Apr 23, 2019 · 1 comment
Closed

Remove shouldFail.reverting.withMessage #30

nventuro opened this issue Apr 23, 2019 · 1 comment
Labels
good first issue Good for newcomers

Comments

@nventuro
Copy link
Contributor

We could simply have reverting have the current withMessage behavior when it receives two arguments (the promise and the message).

Current:

await shouldFail.reverting(promise);
await shouldFail.reverting.withMessage(promise, 'error');

After this:

await shouldFail.reverting(promise);
await shouldFail.reverting(promise, 'error');
@nventuro nventuro added the good first issue Good for newcomers label Apr 23, 2019
@nventuro nventuro mentioned this issue May 11, 2019
Merged
@nventuro
Copy link
Contributor Author

Fixed via #39.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nventuro