Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename shouldFail to expectRevert #39

Merged
merged 15 commits into from May 17, 2019
Merged

Rename shouldFail to expectRevert #39

merged 15 commits into from May 17, 2019

Conversation

nventuro
Copy link
Contributor

Closes #20.

@nventuro nventuro requested a review from frangio May 11, 2019 00:09
CHANGELOG.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@nventuro nventuro requested a review from frangio May 12, 2019 23:36
@nventuro
Copy link
Contributor Author

Tests are failing since some of the tests used shouldFail as a helper, and it now requires a reason string, but the module itself and its API should be ready.

src/expectRevert.js Outdated Show resolved Hide resolved
@frangio frangio changed the title Rename shouldFail to expectFailure. Rename shouldFail to expectRevert May 13, 2019
Co-Authored-By: Francisco Giordano <frangio.1@gmail.com>
Copy link
Contributor

@frangio frangio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docs in the readme need to be updated.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
src/expectRevert.js Outdated Show resolved Hide resolved
src/expectRevert.js Outdated Show resolved Hide resolved
src/expectRevert.js Outdated Show resolved Hide resolved
src/expectRevert.js Outdated Show resolved Hide resolved
nventuro and others added 3 commits May 13, 2019 16:34
Co-Authored-By: Francisco Giordano <frangio.1@gmail.com>
Co-Authored-By: Francisco Giordano <frangio.1@gmail.com>
Co-Authored-By: Francisco Giordano <frangio.1@gmail.com>
src/expectRevert.js Outdated Show resolved Hide resolved
Co-Authored-By: Francisco Giordano <frangio.1@gmail.com>
CHANGELOG.md Show resolved Hide resolved
@nventuro nventuro requested a review from frangio May 16, 2019 17:22
@frangio
Copy link
Contributor

frangio commented May 16, 2019

@nventuro The README was outdated. I added a commit fixing that. Please take a look at 0218e51.

@nventuro nventuro merged commit 8c13195 into master May 17, 2019
@nventuro nventuro deleted the expect-failure branch May 17, 2019 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename shouldFail to expectFailure
2 participants