Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename shouldFail to expectFailure #20

Closed
nventuro opened this issue Mar 26, 2019 · 0 comments · Fixed by #39
Closed

Rename shouldFail to expectFailure #20

nventuro opened this issue Mar 26, 2019 · 0 comments · Fixed by #39
Labels
good first issue Good for newcomers

Comments

@nventuro
Copy link
Contributor

For the same reasons described in OpenZeppelin/openzeppelin-contracts#1687, we probably want to switch to expect-based naming (like expectEvent).
@nventuro nventuro added the good first issue Good for newcomers label Apr 22, 2019
@nventuro nventuro changed the title Rename shouldFail to expectEvent Rename shouldFail to expectFailure May 10, 2019
@nventuro nventuro mentioned this issue May 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename shouldFail to expectRevert OpenZeppelin/openzeppelin-test-helpers
1 participant
@nventuro