Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Typo in Math.sol #5033

Merged

Conversation

dimitriospapathanasiou
Copy link
Contributor

@dimitriospapathanasiou dimitriospapathanasiou commented May 7, 2024

Fixes minor typo in Math.sol documentation

  • Tests
  • Documentation
  • Changeset entry (run npx changeset add)

Copy link

changeset-bot bot commented May 7, 2024

⚠️ No Changeset found

Latest commit: 82ea696

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ernestognw
Copy link
Member

Hi, this doesn't seem to be a typo.

Operation will be marked as failed

vs

Operation will be marked has failed

I'm closing

@ernestognw ernestognw closed this May 8, 2024
@dimitriospapathanasiou
Copy link
Contributor Author

Hi, I corrected it to "as failed" as the word -has- doesn't seem to be in alignment with the sentence meaning.

Nothing of importance though, I just bumped into this while studying the file.

Thanks for your time.

@ernestognw ernestognw reopened this May 13, 2024
@ernestognw
Copy link
Member

Hi, I corrected it to "as failed" as the word -has- doesn't seem to be in alignment with the sentence meaning.

Nothing of importance though, I just bumped into this while studying the file.

Thanks for your time.

Thanks for bumping! I reviewed too fast and concluded it was the opposite (switching as to has)
We get a couple of these PRs that are spam most of the times, sorry 😅

@ernestognw ernestognw merged commit 05d4bf5 into OpenZeppelin:master May 13, 2024
34 of 35 checks passed
@dimitriospapathanasiou
Copy link
Contributor Author

Thank you for reassessing it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants