Extend onlyAuthorized to support extra functions in AccessManager
#5014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d0fd2ab The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ernestognw
commented
Apr 10, 2024
Amxx
reviewed
Apr 11, 2024
| beforeEach('set required role', function () { | ||
| this.method = this.target.fnRestricted.getFragment(); | ||
| this.role = { id: 785913n }; | ||
| this.manager.$_setTargetFunctionRole(this.target, this.method.selector, this.role.id); |
There was a problem hiding this comment.
Should we set the function role for this.manager, this.method.selector ? It feels like we are testing restricted operation on the target when we should test the restricted operation on the manager.
Amxx
reviewed
Apr 11, 2024
| @@ -611,7 +613,7 @@ contract AccessManager is Context, Multicall, IAccessManager { | |||
| */ | |||
| function _getAdminRestrictions( | |||
| bytes calldata data | |||
| ) private view returns (bool restricted, uint64 roleAdminId, uint32 executionDelay) { | |||
| ) private view returns (bool adminRestricted, uint64 roleAdminId, uint32 executionDelay) { | |||
| if (data.length < 4) { | |||
| return (false, 0, 0); | |||
There was a problem hiding this comment.
maybe we want to do
return (false, getTargetFunctionRole(address(this), bytes4(0)), 0);
so that selector 0 can be used to set restriction on the receive() function
There was a problem hiding this comment.
Suggested change
| return (false, 0, 0); | |
| return (false, getTargetFunctionRole(address(this), bytes4(0)), 0); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to extend the AccessManager and use the
onlyAuthorizedmodifer for those functions as well.PR Checklist
npx changeset add)