Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ERC1363 error signatures #5010

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

vittominacori
Copy link
Contributor

In order for the ERC1363 errors to adhere at EIP-6093, I changed from\to with sender\receiver as expressed in eip-6093#parameter-glossary.

Also added missing natspec comments for parameters as they were inserted for all the other errors.

PR Checklist

  • Tests
  • Documentation
  • Changeset entry (run npx changeset add)

Copy link

changeset-bot bot commented Apr 10, 2024

⚠️ No Changeset found

Latest commit: ab4a759

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vittominacori
Copy link
Contributor Author

@Amxx any updates?

@Amxx Amxx added this to the 5.1 milestone Apr 22, 2024
@Amxx Amxx added the documentation Inline comments, guides, and examples. label Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Inline comments, guides, and examples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants