Deduplicate code in scripts/helpers and test/helpers/iterate

[Amxx]

PR Checklist

• Tests
• Documentation
• Changeset entry (run npx changeset add)

[changeset-bot]

⚠️ No Changeset found

Latest commit: 75f671e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[ernestognw]

I checked where the functions are used in the scripts folder and so far:

• chunk: Unused
• product: Unused
• range: In the SafeCast template
• unique: Unused
• zip: Unused
• mapValues: Unused
• capitalize: In multiple templates

Since these are used within automatic generation, these are already checked in the CI so I'm approving.

However, I wonder if it makes sense to keep the helpers in where they're used the most (i.e tests/)

[ernestognw]

CI failing due to #4896. Rerunning

[Amxx]

However, I wonder if it makes sense to keep the helpers in where they're used the most (i.e tests/)

I considered keeping all that code in test/helpers/iterate.js and have the generation script point to that. It felt strange to have "production" scripts rely on testing code... but at the same time, iterate.js sounds like a better description of what the file contains.

[Amxx]

For the record, the "chunk" helpers was used in Forta's early days.

We wanted to relay a lot of transaction trough multicall, but not all at once (we did that in blocks of 16 so that we benefit from multicall while limiting the size of the multicall transaction)

[ernestognw]

It felt strange to have "production" scripts rely on testing code...

Right, that feels weird. I think this is better anyway since we don't ship those scripts. And they're checked in the CI.

[ernestognw]

LGTM