Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update actions/upload-artifact action to v4 #4826

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
+6 −6
Open

Update actions/upload-artifact action to v4 #4826

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
72d4504
Update actions/upload-artifact action to v4
renovate[bot] Jan 11, 2024
dc5011b
Merge branch 'master' into renovate/actions-upload-artifact-4.x
ernestognw Jan 11, 2024
2b66ae2
Uniquely identify uploads
ernestognw Jan 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/actions/gas-compare/action.yml
View file
Open in desktop
Expand Up @@ -43,7 +43,7 @@ runs:
shell: bash
- name: Save report
if: github.event_name != 'pull_request'
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: gasreport
name: gasreport-${{ github.run_id }}-${{ github.run_attempt }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That will be an issue.

The artefact that is uploaded here will later be downloaded by the "Download reference report" job in the same action. This step has no way to know the run_id and run_attempt that created the report.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, yes you're right. I think this is breaking the workflow and the package owners don't seem to provide an easy workaround.

Shall we keep @V3 insetad?

path: ${{ inputs.out_report }}
4 changes: 2 additions & 2 deletions .github/actions/storage-layout/action.yml
View file
Open in desktop
Expand Up @@ -49,7 +49,7 @@ runs:
shell: bash
- name: Save artifacts
if: github.event_name != 'pull_request'
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: layout
name: layout-${{ github.run_id }}-${{ github.run_attempt }}
path: ${{ inputs.out_layout }}
4 changes: 2 additions & 2 deletions .github/workflows/release-cycle.yml
View file
Open in desktop
Expand Up @@ -145,7 +145,7 @@ jobs:
- name: Upload tarball artifact
uses: actions/upload-artifact@v4
with:
name: ${{ github.ref_name }}
name: ${{ github.ref_name }}-${{ github.run_id }}-${{ github.run_attempt }}
path: ${{ steps.pack.outputs.tarball }}
- name: Publish
run: bash scripts/release/workflow/publish.sh
Expand All @@ -172,7 +172,7 @@ jobs:
id: artifact
uses: actions/download-artifact@v4
with:
name: ${{ github.ref_name }}
name: ${{ github.ref_name }}-${{ github.run_id }}-${{ github.run_attempt }}
- name: Check integrity
run: bash scripts/release/workflow/integrity-check.sh
env:
Expand Down