Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the inherited EIP712 name in the Governor contract #4741

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

BCJdevelopment
Copy link

The Governor contract includes a {_name} state variable, but the parent EIP712 contract already uses and stores the exact same value. This is unnecessary duplicate storage.

This PR removes the duplicate {_name} state variable from the Governor, and in the Governor's public "name()" function, returns the result of the internal EIP712 function for retrieving the {_name} value.

PR Checklist

  • Tests
  • Documentation
  • Changeset entry (run npx changeset add)

Copy link

changeset-bot bot commented Nov 15, 2023

⚠️ No Changeset found

Latest commit: 4f48468

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ernestognw
Copy link
Member

This requires a bit more discussion because it may be a breaking change (it was in 4.x).
Here's the context: #4214

@Amxx Amxx added the idea label Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants