Use the inherited EIP712 name in the Governor contract #4741
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Governor contract includes a {_name} state variable, but the parent EIP712 contract already uses and stores the exact same value. This is unnecessary duplicate storage.
This PR removes the duplicate {_name} state variable from the Governor, and in the Governor's public "name()" function, returns the result of the internal EIP712 function for retrieving the {_name} value.
PR Checklist
npx changeset add
)