New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add IERC721MultiMetadata extension #4456
base: master
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 337734b The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
6333d0c
to
531e261
Compare
I'm not a fan of this ERC. Particularly because it includes public setters (IMO that kind of standard should only include getters and events). Also There has been barelly any discussion in the eth magician forum (13 messages, 7 of which are by the author), and its unclear to me who needs/uses that. So I would not go for a full implementation unless we get multiple independant requests by potential users. However this PR is just about adding the interface in |
We need a (simple) changelog entry that says the interface was added. For references, the changelog for 4.9.0 includes
|
@Amxx thanks for looking into this! I just converted to draft since it needs an update – I will get to it soon. Should I drop the dependency on I'd also like to take this opportunity to address your feedback/remarks on the ERC itself (happy to chat on discord, twitter dm or a chat service if you want).
I disagree: in practice I think it is best to standardize the public interface for pinning and unpinning URIs since frontends will likely want to support pinning / unpinning. Therefore a standardized interface for that is much needed.
To get a sense of who is using it you can check out this https://twitter.com/search?q=ERC-7160&src=typed_query The standard is young but artists are starting to adopt it.
I agree, for now let's just add the interface. The standard leaves room for opinionated implementations around how/when one can pin/unpin and add uris. For now you can refer to the Transient Labs implementation (which is again opinionated) (I am not related to TL). |
eaedb8d
to
f8c4455
Compare
@Amxx this is ready for review. Added the changelog entry but please fix/relocate it if is wrong |
Adding a blueprint for the IERC721MultiMetadata (EIP-7160) - an optional EIP-721 multi-metadata extension.
See https://eips.ethereum.org/EIPS/eip-7160
PR Checklist
npx changeset add
) - NO need for this I think