Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved integer square root. #4403

Merged
merged 26 commits into from Feb 16, 2024
Merged

Improved integer square root. #4403

merged 26 commits into from Feb 16, 2024

Commits on Jun 29, 2023

  1. Improved integer square root.

    @chgorman
    chgorman committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    171e5c2 View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2023

  1. Small updates to sqrt function.

    @chgorman
    chgorman committed Jul 22, 2023
    Configuration menu
    Copy the full SHA
    beec057 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2023

  1. Merge branch 'master' into master

    @Amxx
    Amxx committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    a48fda8 View commit details
    Browse the repository at this point in the history

  2. Fixed variable naming.

    @chgorman
    chgorman committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    b6c29b1 View commit details
    Browse the repository at this point in the history

  3. Added some comments to help clarify the algorithm.

    @chgorman
    chgorman committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    0d2bbb3 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2023

  1. Updated edge case for clarity.

    @chgorman
    chgorman committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    1c8e8ab View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2023

  1. Made small improvements.

    @chgorman
    chgorman committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    8e2ab78 View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2024

  1. Merge branch 'master' into master

    @chgorman
    chgorman committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    77db52d View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2024

  1. Added additional comments to include associated proof.

    @chgorman
    chgorman committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    8b3f15f View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into master

    @ernestognw
    ernestognw committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    dc098e8 View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2024

  1. Reduce sqrt comments

    @ernestognw
    ernestognw committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    bd9d969 View commit details
    Browse the repository at this point in the history

  2. Lint

    @ernestognw
    ernestognw committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    dfe2fbc View commit details
    Browse the repository at this point in the history

  3. Correcting return logic

    @chgorman
    chgorman committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    a53d378 View commit details
    Browse the repository at this point in the history

  4. remove overflow check (early) in favor of overflow save math at the e… 

    …nd. This optimized gas cost for 'small' values that are not catched by the initial check.
    @Amxx
    Amxx committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    6c74012 View commit details
    Browse the repository at this point in the history

  5. format

    @Amxx
    Amxx committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    fe8abc3 View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2024

  1. Iterate on comments

    @ernestognw
    ernestognw committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    382ab6f View commit details
    Browse the repository at this point in the history

  2. Iterate on comments

    @ernestognw
    ernestognw committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    c60542b View commit details
    Browse the repository at this point in the history

  3. Lint

    @ernestognw
    ernestognw committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    ddea292 View commit details
    Browse the repository at this point in the history

  4. Codespell

    @ernestognw
    ernestognw committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    360f65d View commit details
    Browse the repository at this point in the history

  5. Iterate on comments

    @ernestognw
    ernestognw committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    4288c74 View commit details
    Browse the repository at this point in the history

  6. rewrite most comments of the sqrt function

    @Amxx
    Amxx committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    256189a View commit details
    Browse the repository at this point in the history

  7. improve

    @Amxx
    Amxx committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    6d00bbd View commit details
    Browse the repository at this point in the history

  8. shift notation e+1 → e

    @Amxx
    Amxx committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    6c8be26 View commit details
    Browse the repository at this point in the history

  9. complete proof

    @Amxx
    Amxx committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    67d0328 View commit details
    Browse the repository at this point in the history

  10. improvement

    @Amxx
    Amxx committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    85a56d6 View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2024

  1. remove reference to Heron's method to avoid confusion

    @Amxx
    Amxx committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    e748bfc View commit details
    Browse the repository at this point in the history