Change admin role allocation in TimelockControler constructor #3722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frangio
reviewed
Sep 22, 2022
Co-authored-by: Francisco <frangio.1@gmail.com>
|
This looks good, my only remaining question is if we should include a warning note in the documentation about past versions of the timelock and their treatment of the deployer account. |
|
Its true that we don't keep past version of the doc for every minor... I think this is something we should do in the future (each version is build from the corresponding release branch) Fell free to add any additional warning. |
frangio
approved these changes
Sep 23, 2022
frangio
pushed a commit
that referenced
this pull request
Sep 23, 2022
Co-authored-by: Francisco <frangio.1@gmail.com> (cherry picked from commit 408055d)
JulissaDantes
pushed a commit
to JulissaDantes/openzeppelin-contracts
that referenced
this pull request
Nov 3, 2022
…ppelin#3722) Co-authored-by: Francisco <frangio.1@gmail.com>
JulissaDantes
pushed a commit
to JulissaDantes/openzeppelin-contracts
that referenced
this pull request
Nov 4, 2022
…ppelin#3722) Co-authored-by: Francisco <frangio.1@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3720