Remove redundant ECDSA constraint #3591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Some more context in #3457. Need to decide on whether it's worth keeping this for error reporting. |
frangio
reviewed
Aug 16, 2022
frangio
changed the title
ronhuafeng
added a commit
to ronhuafeng/openzeppelin-contracts
that referenced
this pull request
Sep 9, 2022
Co-authored-by: Hadrien Croubois <hadrien.croubois@gmail.com> Co-authored-by: Francisco Giordano <frangio.1@gmail.com>
Psirex
added a commit
to lidofinance/lido-dao
that referenced
this pull request
Apr 13, 2023
Walodja1987
added a commit
to divaprotocol/diva-protocol-v1
that referenced
this pull request
Apr 24, 2023
Note that openzeppelin's ECDSA library removed the signature v check in version 4.8 which required a minor adjustment in the relevant tests. Read more about it here: OpenZeppelin/openzeppelin-contracts#3591
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3457
See: https://twitter.com/alexberegszaszi/status/1534461421454606336?s=20&t=H0Dv3ZT2bicx00hLWJk7Fg