Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implicitly clear ERC721 approval on burn #3538

Merged
merged 2 commits into from Jul 9, 2022
Merged

Implicitly clear ERC721 approval on burn #3538

merged 2 commits into from Jul 9, 2022

Conversation

EthanOK
Copy link
Contributor

@EthanOK EthanOK commented Jul 9, 2022 •
edited

Implicitly clear ERC721 approval on burn

Fixes #????

PR Checklist

  • Tests
  • Documentation
  • Changelog entry

@EthanOK
Update ERC721.sol
7a4c814 
 Implicitly clear ERC721 approval on burn
@EthanOK EthanOK changed the title Update ERC721.sol Implicitly clear ERC721 approval on burn Jul 9, 2022
Amxx
Amxx previously approved these changes Jul 9, 2022
View reviewed changes
@Amxx
Copy link
Collaborator

Amxx commented Jul 9, 2022

Thank you @EthanOK for raising that.
We need to update the tests accordingly, and refer to that in the changelog

@Amxx Amxx merged commit 96163c8 into OpenZeppelin:master Jul 9, 2022
ronhuafeng added a commit to ronhuafeng/openzeppelin-contracts that referenced this pull request Sep 9, 2022
@ronhuafeng
Implicitly clear ERC721 approval on burn (OpenZeppelin#3538)
f3e196e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Amxx Amxx Amxx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@EthanOK @Amxx