Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor address-to-hex-string conversion in _checkRole function #3509

Merged
merged 3 commits into from Jun 27, 2022
Merged

Refactor address-to-hex-string conversion in _checkRole function #3509

merged 3 commits into from Jun 27, 2022

Conversation

pcaversaccio
Copy link
Contributor

@pcaversaccio pcaversaccio commented Jun 27, 2022 •
edited

Based on my merged PR #3403 that introduces a function overloading for toHexString, we can make a small refactor of the _checkRole function in AccessControl.sol.

PR Checklist

  • Tests
  • Documentation
  • Changelog entry

@pcaversaccio
fix: use new address-to-string function for _checkRole
5dc8d17 
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
@pcaversaccio
changelog entry
14c3c57 
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
@pcaversaccio pcaversaccio changed the title Refactor string conversion _checkRole Refactor address-to-hex-string conversion in _checkRole function Jun 27, 2022
frangio
frangio approved these changes Jun 27, 2022
View reviewed changes
Copy link
Contributor

@frangio frangio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Refactors don't need to be reflected in the changelog.

@frangio frangio enabled auto-merge (squash) June 27, 2022 20:37
@frangio frangio merged commit 40172c2 into OpenZeppelin:master Jun 27, 2022
@pcaversaccio pcaversaccio deleted the patch-accesscontrol branch June 27, 2022 20:46
ronhuafeng added a commit to ronhuafeng/openzeppelin-contracts that referenced this pull request Sep 9, 2022
@ronhuafeng @frangio
Refactor address-to-hex-string conversion in _checkRole function (O…
4d92c34 
…penZeppelin#3509)

Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
Co-authored-by: Francisco <frangio.1@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frangio frangio frangio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pcaversaccio @frangio