Remove unused using statements in GovernorCompatibilityBravo #3506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GovernorCompatibilityBravo.sol contains two `using` statements which are not used inside that contract. ```javascript using Counters for Counters.Counter; using Timers for Timers.BlockNumber; ``` [Since Solidity 0.7.0](https://docs.soliditylang.org/en/latest/070-breaking-changes.html#functions-and-events), `using` statements no longer affect downstream contracts in inheritance hierarchy. > `using A for B` only affects the contract it is mentioned in. Previously, the effect was inherited. Now, you have to repeat the `using` statement in all derived contracts that make use of the feature. Since these statements are not used inside this contract, and cannot affect anything upstream or downstream of them inheritance, they should be safe to remove.
Amxx
approved these changes
Jun 27, 2022
|
Thank you @DanielVF for finding tat and openning that PR |
Closed
ronhuafeng
added a commit
to ronhuafeng/openzeppelin-contracts
that referenced
this pull request
Sep 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The two using statements in
GovernorCompatibilityBravo.solare not used inside the contract, and cannot affect anything upstream or downstream of them via inheritance. They should be safe to remove.Since Solidity 0.7.0
usingstatements no longer affect downstream contracts in inheritance hierarchy: