Remove redundant require in ERC721 #3434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rotcivegaf @Amxx What do you think about changing all revert reasons that are "__ query for nonexistent token" to instead say "token id not minted"? |
|
Realizing we can treat my previous suggestion independently of this PR. |
frangio
approved these changes
May 27, 2022
|
I don't have a strong opinion. My only concern is that à token could be minted then burned ... and saying that it was not minted could be confusing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove redundant require in
ERC721contract,_isApprovedOrOwnerfunctionPR Checklist