Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use _spendAllowance in ERC20FlashMint #3226

Merged

Conversation

Amxx
Copy link
Collaborator

@Amxx Amxx commented Feb 28, 2022

Internal change to avoid code duplication.

The FlashMint mechanism does a burnFrom, which spends allowance, so let's use the _spendAllowance mechanism for that

PR Checklist

  • Tests

@Amxx Amxx requested a review from frangio March 2, 2022 07:51
@Amxx Amxx changed the title use _spendAllowance in ERC20FlashMint Use _spendAllowance in ERC20FlashMint Mar 2, 2022
@frangio frangio enabled auto-merge (squash) March 8, 2022 19:25
@frangio frangio merged commit f8bfa56 into OpenZeppelin:master Mar 8, 2022
@Amxx Amxx deleted the refactor/ERC20FlashMint/spendAllowance branch March 9, 2022 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants