Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Perform afterTokenTransfer hooks before acceptance check #3215

Merged
merged 1 commit into from Feb 22, 2022
Merged

Perform afterTokenTransfer hooks before acceptance check #3215

merged 1 commit into from Feb 22, 2022

Conversation

Amxx
Copy link
Collaborator

@Amxx Amxx commented Feb 22, 2022 •
edited by frangio

Fixes and issue introduced in #3166 and not yet released. ERC1155 acceptance check should be done at the end to preserve checks-effects-interactions.

PR Checklist

  • Tests
  • Documentation
  • Changelog entry

@Amxx Amxx changed the title Perform afterTokrnTransfer hooks before acceptance check Perform afterTokenTransfer hooks before acceptance check Feb 22, 2022
@Amxx Amxx requested a review from frangio February 22, 2022 17:16
frangio
frangio approved these changes Feb 22, 2022
View reviewed changes
Copy link
Contributor

@frangio frangio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@frangio frangio merged commit f6b614a into OpenZeppelin:master Feb 22, 2022
@Amxx Amxx deleted the fix/ERC1155/afterTransferOrdering branch February 22, 2022 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frangio frangio frangio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Amxx @frangio