Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace immutable with constant for _PERMIT_TYPEHASH #3196

Merged
merged 6 commits into from Mar 9, 2022
Merged

Replace immutable with constant for _PERMIT_TYPEHASH #3196

merged 6 commits into from Mar 9, 2022

Commits on Feb 17, 2022

  1. replace immutable with constant for _PERMIT_TYPEHASH 

    This commit is related to the following issue discussion: OpenZeppelin/contracts-wizard#89 (comment)

Since Solidity version `0.6.12` the `keccak256` of string literals is treated specially and the hash is evaluated at compile time. Since the OpenZeppelin Wizard also uses `constant` for OpenZeppelin's AccessControl's roles declarations, it's good practice to make this consistent.
    @pcaversaccio
    pcaversaccio committed Feb 17, 2022
    Copy the full SHA
    fa5db25 View commit details
    Browse the repository at this point in the history

  2. Update CHANGELOG

    @pcaversaccio
    pcaversaccio committed Feb 17, 2022
    Copy the full SHA
    c869d99 View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2022

  1. Merge branch 'master' into master

    @Amxx
    Amxx committed Mar 9, 2022
    Copy the full SHA
    f1e9a4d View commit details
    Browse the repository at this point in the history

  2. fix: ensure transpiler compatibility

    @pcaversaccio
    pcaversaccio committed Mar 9, 2022
    Copy the full SHA
    201d3bf View commit details
    Browse the repository at this point in the history

  3. fix: fixing var-name-mixedcase

    @pcaversaccio
    pcaversaccio committed Mar 9, 2022
    Copy the full SHA
    20d6c00 View commit details
    Browse the repository at this point in the history

  4. prettier & lint check 

    Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
    @pcaversaccio
    pcaversaccio committed Mar 9, 2022
    Copy the full SHA
    d7fddb9 View commit details
    Browse the repository at this point in the history