Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve security of the onlyGovernance modifier #3147

Merged
merged 22 commits into from Feb 18, 2022
Merged

Improve security of the onlyGovernance modifier #3147

merged 22 commits into from Feb 18, 2022

Commits on Jan 27, 2022

  1. add a protection mechanism to prevent relaying transaction that are not 

    part of an execute operation
    @Amxx
    Amxx committed Jan 27, 2022
    Copy the full SHA
    b413688 View commit details
    Browse the repository at this point in the history

  2. more accurate relay authorization

    @Amxx
    Amxx committed Jan 27, 2022
    Copy the full SHA
    e5d80c7 View commit details
    Browse the repository at this point in the history

  3. force reset the relay authorizations after executions

    @Amxx
    Amxx committed Jan 27, 2022
    Copy the full SHA
    52b2ea2 View commit details
    Browse the repository at this point in the history

Commits on Jan 28, 2022

  1. refactor of the onlyGovernor modifier

    @Amxx
    Amxx committed Jan 28, 2022
    Copy the full SHA
    052fa20 View commit details
    Browse the repository at this point in the history

  2. only whitelist when executor is not governor itself

    @frangio
    frangio committed Jan 28, 2022
    Copy the full SHA
    b257239 View commit details
    Browse the repository at this point in the history

  3. fix lint

    @Amxx
    Amxx committed Jan 28, 2022
    Copy the full SHA
    6a61fcc View commit details
    Browse the repository at this point in the history

  4. add private function for call permission management

    @Amxx
    Amxx committed Jan 28, 2022
    Copy the full SHA
    84a1dd1 View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2022

  1. Merge branch 'master' into experimantal/Governor/authorizeRelay

    @Amxx
    Amxx committed Feb 16, 2022
    Copy the full SHA
    519d647 View commit details
    Browse the repository at this point in the history

  2. use deque

    @Amxx
    Amxx committed Feb 16, 2022
    Copy the full SHA
    ac524df View commit details
    Browse the repository at this point in the history

  3. fix lint

    @Amxx
    Amxx committed Feb 16, 2022
    Copy the full SHA
    1f4896f View commit details
    Browse the repository at this point in the history

  4. remove unecessary dependency

    @Amxx
    Amxx committed Feb 16, 2022
    Copy the full SHA
    332bc3e View commit details
    Browse the repository at this point in the history

  5. remove unecessary dependency

    @Amxx
    Amxx committed Feb 16, 2022
    Copy the full SHA
    43e2e3d View commit details
    Browse the repository at this point in the history

  6. comment rephrasing

    @Amxx
    Amxx committed Feb 16, 2022
    Copy the full SHA
    7e75fab View commit details
    Browse the repository at this point in the history

Commits on Feb 18, 2022

  1. Update contracts/governance/Governor.sol 

    Co-authored-by: Francisco Giordano <frangio.1@gmail.com>
    @Amxx @frangio
    Amxx and frangio committed Feb 18, 2022
    Copy the full SHA
    b7fe0d3 View commit details
    Browse the repository at this point in the history

  2. cache keccak256(_msgData())

    @Amxx
    Amxx committed Feb 18, 2022
    Copy the full SHA
    d380812 View commit details
    Browse the repository at this point in the history

  3. use Context

    @Amxx
    Amxx committed Feb 18, 2022
    Copy the full SHA
    319c0d8 View commit details
    Browse the repository at this point in the history

  4. lint

    @frangio
    frangio committed Feb 18, 2022
    Copy the full SHA
    d2913ac View commit details
    Browse the repository at this point in the history

  5. conditionnal clear

    @Amxx
    Amxx committed Feb 18, 2022
    Copy the full SHA
    65d5f4d View commit details
    Browse the repository at this point in the history

  6. add test to cover queue.clear()

    @frangio
    frangio committed Feb 18, 2022
    Copy the full SHA
    b0bbcc0 View commit details
    Browse the repository at this point in the history

  7. lint

    @frangio
    frangio committed Feb 18, 2022
    Copy the full SHA
    5e41153 View commit details
    Browse the repository at this point in the history

  8. write more extended docs for onlyGovernance

    @frangio
    frangio committed Feb 18, 2022
    Copy the full SHA
    ee1a34b View commit details
    Browse the repository at this point in the history

  9. add changelog entry

    @frangio
    frangio committed Feb 18, 2022
    Copy the full SHA
    eca234f View commit details
    Browse the repository at this point in the history