Improve clarity of error messages in functions checking token ownership #3121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…token', distinguishing from contract ownership OpenZeppelin#3120
|
Replaced with #3254 (see issue for rational) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #3120
As described in the issue, I have expanded the (hopefully complete set) of error messages in which the user is informed they have insufficient ownership or approval for an action on a token. The addition is essentially
not owner->not token ownerto distinguish from contract ownership.One additional change was made in an instance where an error message for transferring tokens did not begin with the term
transfer caller, instead justcaller. I addedtransferfor uniformity.Tests have been updated to check against updated error messages.
PR Checklist