Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend Governor with parameterized votes #3043

Merged
merged 19 commits into from Mar 1, 2022
Merged

Extend Governor with parameterized votes #3043

merged 19 commits into from Mar 1, 2022

Commits on Feb 26, 2022

  1. Add a data parameter to the _countVote interface

    @apbendi
    apbendi committed Feb 26, 2022
    Copy the full SHA
    3bdd3ec View commit details
    Browse the repository at this point in the history

  2. linter fix

    @apbendi
    apbendi committed Feb 26, 2022
    Copy the full SHA
    b86cbc8 View commit details
    Browse the repository at this point in the history

  3. Rename governor extension data extension to params

    @apbendi
    apbendi committed Feb 26, 2022
    Copy the full SHA
    6aaad84 View commit details
    Browse the repository at this point in the history

  4. Remove castVoteWithParams without reason parameter

    @apbendi
    apbendi committed Feb 26, 2022
    Copy the full SHA
    287aa4f View commit details
    Browse the repository at this point in the history

  5. Add a virtual method specifying default additional voting params

    @apbendi
    apbendi committed Feb 26, 2022
    Copy the full SHA
    92e939f View commit details
    Browse the repository at this point in the history

  6. Extend parameterized Governor customization to include vote weight ca… 

    …lculation
    @Amxx @apbendi
    Amxx authored and apbendi committed Feb 26, 2022
    Copy the full SHA
    b7eb845 View commit details
    Browse the repository at this point in the history

  7. Mock and test usage of Govenance extension params

    @apbendi
    apbendi committed Feb 26, 2022
    Copy the full SHA
    ead0d51 View commit details
    Browse the repository at this point in the history

  8. Implement and test Govenor castVoteWithReasonAndParamsBySig method

    @apbendi
    apbendi committed Feb 26, 2022
    Copy the full SHA
    0b49a65 View commit details
    Browse the repository at this point in the history

  9. Add VoteCastWithParams event emitted when params are included

    @apbendi
    apbendi committed Feb 26, 2022
    Copy the full SHA
    0d5f887 View commit details
    Browse the repository at this point in the history

  10. Document changes associated with Governor extension params

    @apbendi
    apbendi committed Feb 26, 2022
    Copy the full SHA
    d08f61a View commit details
    Browse the repository at this point in the history

  11. Overload _castVote and curry using default parameters

    @apbendi
    apbendi committed Feb 26, 2022
    Copy the full SHA
    a49eb41 View commit details
    Browse the repository at this point in the history

  12. Silence compiler warnings by removing parameter name

    @apbendi
    apbendi committed Feb 26, 2022
    Copy the full SHA
    0823a41 View commit details
    Browse the repository at this point in the history

  13. Fix doc comments related to getting votes

    @apbendi
    apbendi committed Feb 26, 2022
    Copy the full SHA
    214259c View commit details
    Browse the repository at this point in the history

  14. Simplify Changelog description and include instructions for resolving… 

    … breaking changes
    @apbendi
    apbendi committed Feb 26, 2022
    Copy the full SHA
    970556e View commit details
    Browse the repository at this point in the history

  15. Fix Governor linting issue

    @apbendi
    apbendi committed Feb 26, 2022
    Copy the full SHA
    6e2b447 View commit details
    Browse the repository at this point in the history

  16. Add public getVotesWithParams to Governor

    @apbendi
    apbendi committed Feb 26, 2022
    Copy the full SHA
    455efe8 View commit details
    Browse the repository at this point in the history

  17. Properly call super in GovernorWithParamsMock

    @apbendi
    apbendi committed Feb 26, 2022
    Copy the full SHA
    8722c5c View commit details
    Browse the repository at this point in the history

  18. Directly verify vote totals when testing parameterized voting

    @apbendi
    apbendi committed Feb 26, 2022
    Copy the full SHA
    b4cd7c4 View commit details
    Browse the repository at this point in the history

  19. Add a note about params to COUNTING_MODE documentation

    @apbendi
    apbendi committed Feb 26, 2022
    Copy the full SHA
    78c9968 View commit details
    Browse the repository at this point in the history