Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an internal _useNonce(address) function in ERC20Permit #2565

Merged
merged 5 commits into from Mar 10, 2021
Merged

Add an internal _useNonce(address) function in ERC20Permit #2565

merged 5 commits into from Mar 10, 2021

Conversation

Amxx
Copy link
Collaborator

@Amxx Amxx commented Mar 5, 2021

Fixes #2564

PR Checklist

  • Tests
  • Documentation
  • Changelog entry

@Amxx Amxx changed the title Feature/erc20 permit increment internal Add an internal _useNonce(address) function in ERC20Permit Mar 5, 2021
@frangio
Copy link
Contributor

frangio commented Mar 8, 2021

nonces should be made virtual now that it is possible to override _useNonce.

@Amxx Amxx force-pushed the feature/ERC20PermitIncrementInternal branch from 62219e2 to a8ab6ff Compare March 10, 2021 14:31
frangio
frangio approved these changes Mar 10, 2021
View reviewed changes
Copy link
Contributor

@frangio frangio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@frangio frangio merged commit 5171e46 into OpenZeppelin:master Mar 10, 2021
@Amxx Amxx deleted the feature/ERC20PermitIncrementInternal branch March 10, 2021 15:34
@dependabot dependabot bot mentioned this pull request Mar 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frangio frangio frangio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add an internal _useNonce(address) function in ERC20Permit
2 participants
@Amxx @frangio