Fix/chai.expect for chai.should #1804
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
June 18, 2019 16:53
alanarvelo
changed the title
nventuro
reviewed
Jun 19, 2019
There was a problem hiding this comment.
Wow, great work @alanarvelo, thank you very much for this! This looks fine by me, but I also want @frangio to take a look, since all tests are affected by this PR.
|
We've merged #1780 now which existed prior to this PR. Sorry about that @alanarvelo! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses Issue Fixes #1687 which explains why chai.expect is preferred over chai.should.
Added
const { expect } = require('chai');to each file that used chai.should (~56 files) and then replaced instances ofobj.should.equal()forexpect(obj).to.equal().Only modified test files.