ERC2771Forwarder has a flaky tampered signature test

[ernestognw]

📝 Details

In recent CI runs (e.g this one), the CI has failed because the ERC2771Forwarder tests use a signatured that's directly modified without any validation.

This seems to be causing a problem in @noble, the package used for secp256k1 operations:

Error: Cannot find square root
      at sqrtMod (node_modules/@noble/secp256k1/lib/index.js:642:15)
      at Function.fromCompressedHex (node_modules/@noble/secp256k1/lib/index.js:315:17)
      at Function.fromHex (node_modules/@noble/secp256k1/lib/index.js:344:25)
      at Function.fromSignature (node_modules/@noble/secp256k1/lib/index.js:364:25)
      at Object.recoverPublicKey (node_modules/@noble/secp256k1/lib/index.js:843:18)
      at Function.recoverPublicKey (node_modules/ethers/src.ts/crypto/signing-key.ts:182:34)
      at recoverAddress (node_modules/ethers/src.ts/transaction/address.ts:27:38)
      at Proxy.verifyTypedData (node_modules/ethers/src.ts/hash/typed-data.ts:614:26)
      at Context.<anonymous> (test/metatx/ERC2771Forwarder.test.js:139:32)
      at processTicksAndRejections (node:internal/process/task_queues:95:5)

Copying stacktrace for the record.