Add public getVotesWithParams to Governor

OpenZeppelin · Feb 26, 2022 · 455efe8 · 455efe8
1 parent 6e2b447
commit 455efe8
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 1 deletion.
diff --git a/contracts/governance/Governor.sol b/contracts/governance/Governor.sol
@@ -94,7 +94,8 @@ abstract contract Governor is Context, ERC165, EIP712, IGovernor {
             interfaceId ==
             (type(IGovernor).interfaceId ^
                 this.castVoteWithReasonAndParams.selector ^
-                this.castVoteWithReasonAndParamsBySig.selector) ||
+                this.castVoteWithReasonAndParamsBySig.selector ^
+                this.getVotesWithParams.selector) ||
             interfaceId == type(IGovernor).interfaceId ||
             super.supportsInterface(interfaceId);
     }
@@ -392,6 +393,17 @@ abstract contract Governor is Context, ERC165, EIP712, IGovernor {
         return _getVotes(account, blockNumber, _defaultParams());
     }
 
+    /**
+     * @dev See {IGovernor-getVotesWithParams}.
+     */
+    function getVotesWithParams(
+        address account,
+        uint256 blockNumber,
+        bytes memory params
+    ) public view virtual override returns (uint256) {
+        return _getVotes(account, blockNumber, params);
+    }
+
     /**
      * @dev See {IGovernor-castVote}.
      */

diff --git a/contracts/governance/IGovernor.sol b/contracts/governance/IGovernor.sol
@@ -166,6 +166,16 @@ abstract contract IGovernor is IERC165 {
      */
     function getVotes(address account, uint256 blockNumber) public view virtual returns (uint256);
 
+    /**
+     * @notice module:reputation
+     * @dev Voting power of an `account` at a specific `blockNumber` given additional encoded parameters.
+     */
+    function getVotesWithParams(
+        address account,
+        uint256 blockNumber,
+        bytes memory params
+    ) public view virtual returns (uint256);
+
     /**
      * @notice module:voting
      * @dev Returns weither `account` has cast a vote on `proposalId`.

diff --git a/test/utils/introspection/SupportsInterface.behavior.js b/test/utils/introspection/SupportsInterface.behavior.js
@@ -81,6 +81,7 @@ const INTERFACES = {
     'votingPeriod()',
     'quorum(uint256)',
     'getVotes(address,uint256)',
+    'getVotesWithParams(address,uint256,bytes)',
     'hasVoted(uint256,address)',
     'propose(address[],uint256[],bytes[],string)',
     'execute(address[],uint256[],bytes[],bytes32)',