Skip to content

Commit

Permalink
fix secure upgrade pattern
Browse files Browse the repository at this point in the history
  • Loading branch information
Amxx committed Mar 23, 2021
1 parent e1f8449 commit 1a477c7
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
5 changes: 2 additions & 3 deletions contracts/proxy/ERC1967/ERC1967Upgrade.sol
Expand Up @@ -69,9 +69,8 @@ abstract contract ERC1967Upgrade is ERC1967Storage {
Address.functionDelegateCall(
newImplementation,
abi.encodeWithSignature(
"upgradeToAndCall(address,bytes)",
oldImplementation,
bytes("")
"upgradeTo(address)",
oldImplementation
)
);
upgradePending.value = false;
Expand Down
2 changes: 1 addition & 1 deletion test/proxy/UUPS/Proxiable.test.js
Expand Up @@ -5,7 +5,7 @@ const ProxiableMock = artifacts.require('ProxiableMock');
const ProxiableUnsafeMock = artifacts.require('ProxiableUnsafeMock');
const ProxiableBrokenMock = artifacts.require('ProxiableBrokenMock');

contract('ERC1967Upgrade', function (accounts) {
contract('Proxiable', function (accounts) {
before(async function () {
this.testimpl0 = await ProxiableMock.new();
this.testimpl1 = await ProxiableMock.new();
Expand Down

0 comments on commit 1a477c7

Please sign in to comment.