Obtenir les CGUs de plusieurs fournisseurs #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ndpnt
force-pushed
the
multiple-service-providers
branch
from
a94353a
to
172f5e9
Compare
MattiSG
requested changes
Jun 12, 2020
There was a problem hiding this comment.
Tests fail at execution due to two different errors
- Repeated for all tests that try to commit:
Error: _commit for test_service_provider document terms_of_service experienced an error: MissingNameError: No name was provided for author in the argument or in the .git/config file. - In
CGUs#updateTerms:Error: ENOENT: no such file or directory, unlink 'cgus/test/data/sanitized/first_provider/tos.md'.
General feedback
- I see the added value of logging what's going on but I'm wondering if it's not a bit too many
console.log. It's in the code now and the messages have been properly written, so it's fine for me to leave them there, but I feel we should have a discussion around the logging interface and expectations 🙂 - I feel it might be worth adding ESlint considering that quite a few comments were around meaningless stuff such as semicolons or spacing 🙂
src/history/persistor.js
Outdated
|
|
||
| if (!fsApi.existsSync(directory)){ | ||
| if (!fsApi.existsSync(directory)){ |
There was a problem hiding this comment.
Suggested change
| if (!fsApi.existsSync(directory)){ | |
| if (!fsApi.existsSync(directory)) { |
src/history/persistor.js
Outdated
Comment on lines
28
to
29
| if (!fsApi.existsSync(directory)){ | ||
| fsApi.mkdirSync(directory); |
There was a problem hiding this comment.
Because it needs to exist before writing the file
There was a problem hiding this comment.
Yep I can do that, I didn't see that I already import fs.promises
|
It's weird for your tests, everything is ok on my machine. All tests pass. Do you have a |
|
I tried to add eslint but as we use |
Great! Thanks for this 🙂 |
MattiSG
approved these changes
Jun 12, 2020
martinratinaud
pushed a commit
that referenced
this pull request
Aug 6, 2021
Obtenir les CGUs de plusieurs fournisseurs
martinratinaud
pushed a commit
that referenced
this pull request
Aug 6, 2021
Obtenir les CGUs de plusieurs fournisseurs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #12