New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider extraction errors as expected operational errors without crashing the engine #1069
Conversation
Also allow passing no params to the `track` function
d8383eb
to
5cf29dc
Compare
5cf29dc
to
9bead1c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It sounds great and, well done!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like very impactful and well-thought-out changes! I didn't review src/archivist/extract/index.test.js
.
test/fixtures/termsNoText.pdf
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested rename:
termsWithNoText
ortermsWithoutText
.
Co-authored-by: Matti Schneider <matti@opentermsarchive.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming typos and copywriting changes are taken into account, LGTM! 👏
So many fixes and improvements, nice! There were a few riders though, such as the terms types filtering and count correction; it's always better to ship them separately 😉
Co-authored-by: Clément Biron <clement.biron@gmail.com>
Co-authored-by: Matti Schneider <matti@opentermsarchive.org>
Co-authored-by: Matti Schneider <matti@opentermsarchive.org>
Changed
Added
empty content
to reported issues on GitHub when server returns empty content or when PDF content is unextractableinvalid selector
to reported issues on GitHub when CSS selector is invalidFixed
--types
is not ignored--types
Other technical improvements:
logger
silent intest
envtrack
functionfetch
function will bubble asFetchDocumentError
extract
function will bubble asExtractDocumentError