Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Opening all files inside .tar.gz #6593

Merged
merged 1 commit into from May 21, 2024

Conversation

DaxServer
Copy link
Contributor

Simplified the opening of tar archives by removing unnecessary check for the first entry and directly returning the TarArchiveInputStream in the tryOpenAsArchive method. Also updated the usage of deprecated getNextTarEntry to getNextEntry in ImportingUtilities.java.

Supports #5792

Simplified the opening of tar archives by removing unnecessary check for the
first entry and directly returning the `TarArchiveInputStream` in the `tryOpenAsArchive`
method. Also updated the usage of deprecated `getNextTarEntry` to `getNextEntry` in
ImportingUtilities.java.
Copy link
Sponsor Member

@wetneb wetneb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about the long delay in reviewing this!
On the surface I was worried that this would break the ability to read Gzipped files which are not TAR archives but I checked that it isn't the case.

@wetneb wetneb merged commit 24947a3 into OpenRefine:master May 21, 2024
19 checks passed
@DaxServer DaxServer deleted the fix-.tar.gz branch May 21, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants