Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: openrefine icon compliant with new MacOS guidelines #6592

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

teolemon
Copy link

@teolemon teolemon commented May 8, 2024

Fixes #6399

What

  • feat: openrefine icon compliant with new MacOS guidelines

@github-actions github-actions bot added Type: Feature Request Identifies requests for new features or enhancements. These involve proposing new improvements. Theme: UX/Usability Focuses on issues related to improving the overall user experience and interaction flow. Platform: macOS Denotes that the item is relevant to macOS users or macOS-specific environments Type: Design Discussions Indicates the need for discussion on issues related to UI/UX, accessibility or design refinements. labels May 10, 2024
@tfmorris
Copy link
Member

Thanks!

Pinging @OpenRefine/designers to see if they have any feedback.

@wetneb
Copy link
Sponsor Member

wetneb commented May 21, 2024

When pinging designers it's generally helpful to provide a screenshot for them to be able to judge the changes easily - especially since GitHub doesn't provide previews for .icns files. Here is one:
Screenshot 2024-05-21 at 10 06 51
(the logo on the left-hand side is the new one, the old one is on the right-hand side)

@thadguidry
Copy link
Member

thadguidry commented May 21, 2024

still think we can go just a bit larger... to the maximum that's allowed for the icon grid? as I mentioned in this comment #6399 (comment)
Also add a drop shadow as I mentioned.
@wetneb I mean, look how our OpenRefine logo inside the white box compares to your Keys app as an example.

Copy link
Sponsor Member

@wetneb wetneb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thadguidry I don't think we can go much larger because we are limited on the width by the white frame.

I'd merge this soon unless @teolemon wants to do further tweaks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Platform: macOS Denotes that the item is relevant to macOS users or macOS-specific environments Theme: UX/Usability Focuses on issues related to improving the overall user experience and interaction flow. Type: Design Discussions Indicates the need for discussion on issues related to UI/UX, accessibility or design refinements. Type: Feature Request Identifies requests for new features or enhancements. These involve proposing new improvements.
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

Add an icon in line with the new visual guidelines of MacOS
4 participants