Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wikibase: Alert the user when they do not provide an edit summary #6591

Conversation

t8210103
Copy link
Contributor

@t8210103 t8210103 commented May 7, 2024

Closes #6306

Changes proposed in this pull request:

  • Unfortunately, i couldn't configure the request for a working "required" tag inside the HTML code.
  • Directly implementing the "required" tag in the appropriate HTML "input" tag did not work, since the form isn't directly submitted from the HTML code, but from a JavaScript code that doesn't recognize the "required" tag.
  • Although, as i noticed in different parts off the project, problems as such are dealt with the pop-up window that follows:
    Screenshot 2024-05-07 202645
    -(The previous message pops-up when the user clicks "next" without choosing a file in the "create project" section).
    -What this PR changes, is instead of focusing to the box next to "summary", it pops-up the following message:
    Screenshot 2024-05-07 202618
    -(This validation message was already implemented inside the code but never reached).

@github-actions github-actions bot added Type: Feature Request Identifies requests for new features or enhancements. These involve proposing new improvements. Status: Pending Review Indicates that the issue or pull request is awaiting review by project maintainers or collaborators labels May 7, 2024
Copy link
Sponsor Member

@wetneb wetneb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for having a look!

Reusing the validation logic from the backend is not a bad idea, but I am reluctant to have it include a Java exception class name because it's an internal implementation detail that isn't very readable and therefore shouldn't be presented to users.

Also, opening a modal dialog strikes me as rather "obstructive" since it requires the user to first close the modal, then manually focus the summary field, before they can start describing their changes. Don't you like pointing the user to the field directly? It feels like a widespread practice to me.

@wetneb wetneb changed the title Potentially Closes #6306. Alert the user when they do not provide an edit summary May 13, 2024
@wetneb wetneb changed the title Alert the user when they do not provide an edit summary wikibase: Alert the user when they do not provide an edit summary May 13, 2024
@t8210103
Copy link
Contributor Author

Absolutely, I understand your concerns. I will close this pull request for now, and if I manage to address these points, I'll open a new one.

@t8210103 t8210103 closed this May 15, 2024
@t8210103 t8210103 deleted the issue-6306-mandatory-summary-clearer branch May 15, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Pending Review Indicates that the issue or pull request is awaiting review by project maintainers or collaborators Type: Feature Request Identifies requests for new features or enhancements. These involve proposing new improvements.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make it clear that summary is mandatory for Wikibase upload
2 participants