Fix class mapping mechanism broken by the migration to Jackson #6480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tfmorris any thoughts on this one? |
|
@wetneb Sorry for the delay. I'll try to review this shortly. |
tfmorris
reviewed
May 20, 2024
There was a problem hiding this comment.
Yet another apology, but I am actively reviewing it now -- and I do appreciate the effort you put into researching and implementing a solution. Just a question (inline with code) to start while I hunt for some legacy projects.
It looks like this mechanism would help with the com.google.refine -> org.openrefine case (assuming that we can't get rid of the embedded class names), so that's useful, but I'd really prefer not to have classnames embedded at all since it seems inherently fragile (and I don't think legacy projects have them).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of a discussion with @tfmorris.