Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor EngineDependentCommand & Command hierarchy. Fixes #6443 #6452

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Refactor EngineDependentCommand & Command hierarchy. Fixes #6443 #6452

wants to merge 1 commit into from

Conversation

tfmorris
Copy link
Member

Fixes #6443

Changes proposed in this pull request:

  • Introduce an OperationCommand class to hold the bulk of the EngineDependentCommand implementation and move EngineDependentCommand to be its subclass.
  • refactor Commands which create Operations to use the new class and delete all the code made redundant.

@github-actions github-actions bot added Type: Feature Request Identifies requests for new features or enhancements. These involve proposing new improvements. Status: Pending Review Indicates that the issue or pull request is awaiting review by project maintainers or collaborators labels Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Pending Review Indicates that the issue or pull request is awaiting review by project maintainers or collaborators Type: Feature Request Identifies requests for new features or enhancements. These involve proposing new improvements.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor command class hierarchy to better support engine independent commands
1 participant
@tfmorris