Encode strings before using them as URLs for Add Column by Fetching URLs - fixes #6140 #6142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Type: Feature Request
tfmorris
removed
the
Status: Pending Review
tfmorris
force-pushed
the
6140-encode-urls-for-fetch
branch
from
a861035
to
726f07b
Compare
tfmorris
force-pushed
the
6140-encode-urls-for-fetch
branch
from
726f07b
to
4da8049
Compare
wetneb
requested changes
Dec 7, 2023
main/src/com/google/refine/operations/column/ColumnAdditionByFetchingURLsOperation.java
Outdated
Show resolved
Hide resolved
tfmorris
force-pushed
the
6140-encode-urls-for-fetch
branch
from
4da8049
to
3fbc475
Compare
tfmorris
force-pushed
the
6140-encode-urls-for-fetch
branch
from
3fbc475
to
a969ac5
Compare
|
@wetneb ping. I addressed your comment a couple of weeks ago and this is ready for re-review. |
wetneb
reviewed
Feb 28, 2024
| final String BASE_URL = "https://example.com/"; | ||
| final String TEST_URL = BASE_URL + ARABIC_PATH; | ||
| assertEquals(HttpClient.getEscapedUrl(TEST_URL), BASE_URL + UrlEscapers.urlPathSegmentEscaper().escape(ARABIC_PATH)); | ||
| } |
There was a problem hiding this comment.
Would it not be worth adding some test cases to demonstrate the handling of already-escaped URLs, to make sure they are not doubly escaped?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6140
Changes proposed in this pull request:
One question I have is whether we should be percent-decoding the string before feeding it to the URL encoder. This could potentially make it more compatible with existing recipes which uses
.encode("url")as well as allowing the use of other sources of pre-encoded URLs, but is opening up a little bit of a can of worms.Note also that this is based on the branch with the fix for #6137 and includes it, on the assumption that it will be reviewed and merged first.